Clean up cast syntax and rules
This commit is contained in:
@@ -439,31 +439,7 @@ public record DereferenceNode(List<Token> Tokens, NubType Type, ExpressionNode T
|
||||
}
|
||||
}
|
||||
|
||||
public record ConvertIntNode(List<Token> Tokens, ExpressionNode Value, int StartWidth, int TargetWidth, bool StartSignedness, bool TargetSignedness) : RValueExpressionNode(Tokens, new NubIntType(TargetSignedness, TargetWidth))
|
||||
{
|
||||
public override IEnumerable<Node> Children()
|
||||
{
|
||||
yield return Value;
|
||||
}
|
||||
}
|
||||
|
||||
public record ConvertFloatNode(List<Token> Tokens, ExpressionNode Value, int StartWidth, int TargetWidth) : RValueExpressionNode(Tokens, new NubFloatType(TargetWidth))
|
||||
{
|
||||
public override IEnumerable<Node> Children()
|
||||
{
|
||||
yield return Value;
|
||||
}
|
||||
}
|
||||
|
||||
public record ConvertCStringToStringNode(List<Token> Tokens, ExpressionNode Value) : RValueExpressionNode(Tokens, new NubStringType())
|
||||
{
|
||||
public override IEnumerable<Node> Children()
|
||||
{
|
||||
yield return Value;
|
||||
}
|
||||
}
|
||||
|
||||
public record SizeBuiltinNode(List<Token> Tokens, NubType Type, NubType TargetType) : RValueExpressionNode(Tokens, Type)
|
||||
public record SizeNode(List<Token> Tokens, NubType Type, NubType TargetType) : RValueExpressionNode(Tokens, Type)
|
||||
{
|
||||
public override IEnumerable<Node> Children()
|
||||
{
|
||||
@@ -471,7 +447,7 @@ public record SizeBuiltinNode(List<Token> Tokens, NubType Type, NubType TargetTy
|
||||
}
|
||||
}
|
||||
|
||||
public record FloatToIntBuiltinNode(List<Token> Tokens, NubType Type, ExpressionNode Value, NubFloatType ValueType, NubIntType TargetType) : RValueExpressionNode(Tokens, Type)
|
||||
public record CastNode(List<Token> Tokens, NubType Type, ExpressionNode Value) : RValueExpressionNode(Tokens, Type)
|
||||
{
|
||||
public override IEnumerable<Node> Children()
|
||||
{
|
||||
@@ -479,14 +455,6 @@ public record FloatToIntBuiltinNode(List<Token> Tokens, NubType Type, Expression
|
||||
}
|
||||
}
|
||||
|
||||
public record ConstArrayToSliceNode(List<Token> Tokens, NubType Type, ExpressionNode Array) : RValueExpressionNode(Tokens, Type)
|
||||
{
|
||||
public override IEnumerable<Node> Children()
|
||||
{
|
||||
yield return Array;
|
||||
}
|
||||
}
|
||||
|
||||
public record EnumReferenceIntermediateNode(List<Token> Tokens, string Module, string Name) : IntermediateExpression(Tokens)
|
||||
{
|
||||
public override IEnumerable<Node> Children()
|
||||
|
||||
@@ -309,69 +309,97 @@ public sealed class TypeChecker
|
||||
FloatLiteralSyntax expression => CheckFloatLiteral(expression, expectedType),
|
||||
MemberAccessSyntax expression => CheckMemberAccess(expression, expectedType),
|
||||
StructInitializerSyntax expression => CheckStructInitializer(expression, expectedType),
|
||||
InterpretBuiltinSyntax expression => CheckExpression(expression.Target, expectedType) with { Type = ResolveType(expression.Type) },
|
||||
SizeBuiltinSyntax expression => new SizeBuiltinNode(node.Tokens, new NubIntType(false, 64), ResolveType(expression.Type)),
|
||||
FloatToIntBuiltinSyntax expression => CheckFloatToInt(expression, expectedType),
|
||||
InterpretSyntax expression => CheckExpression(expression.Target, expectedType) with { Type = ResolveType(expression.Type) },
|
||||
SizeSyntax expression => new SizeNode(node.Tokens, new NubIntType(false, 64), ResolveType(expression.Type)),
|
||||
CastSyntax expression => CheckCast(expression, expectedType),
|
||||
_ => throw new ArgumentOutOfRangeException(nameof(node))
|
||||
};
|
||||
|
||||
switch (expectedType)
|
||||
if (expectedType != null)
|
||||
{
|
||||
// note(nub31): Implicit conversion of const array to unsized array
|
||||
case NubArrayType when result.Type is NubConstArrayType constArrayType:
|
||||
{
|
||||
return result with { Type = new NubArrayType(constArrayType.ElementType) };
|
||||
}
|
||||
// note(nub31): Implicit conversion of const array to slice
|
||||
case NubSliceType when result.Type is NubConstArrayType constArrayType:
|
||||
{
|
||||
return new ConstArrayToSliceNode(result.Tokens, new NubSliceType(constArrayType.ElementType), result);
|
||||
}
|
||||
// note(nub31): Implicit conversion of int to larger int
|
||||
case NubIntType expectedIntType when result.Type is NubIntType intType && expectedIntType.Width > intType.Width:
|
||||
{
|
||||
return new ConvertIntNode(result.Tokens, result, intType.Width, expectedIntType.Width, intType.Signed, expectedIntType.Signed);
|
||||
}
|
||||
// note(nub31): Implicit conversion of f32 to f64
|
||||
case NubFloatType expectedFloatType when result.Type is NubFloatType floatType && expectedFloatType.Width > floatType.Width:
|
||||
{
|
||||
return new ConvertFloatNode(result.Tokens, result, floatType.Width, expectedFloatType.Width);
|
||||
}
|
||||
// note(nub31): Implicit conversion of cstring to string
|
||||
case NubStringType when result.Type is NubCStringType:
|
||||
{
|
||||
return new ConvertCStringToStringNode(result.Tokens, result);
|
||||
}
|
||||
// note(nub31): No implicit conversion was possible or the result value was already the correct type
|
||||
default:
|
||||
if (result.Type == expectedType)
|
||||
{
|
||||
return result;
|
||||
}
|
||||
|
||||
if (IsCastAllowed(result.Type, expectedType))
|
||||
{
|
||||
return new CastNode(result.Tokens, expectedType, result);
|
||||
}
|
||||
}
|
||||
|
||||
return result;
|
||||
}
|
||||
|
||||
// todo(nub31): Infer int type instead of explicit type syntax
|
||||
private FloatToIntBuiltinNode CheckFloatToInt(FloatToIntBuiltinSyntax expression, NubType? _)
|
||||
private ExpressionNode CheckCast(CastSyntax expression, NubType? expectedType)
|
||||
{
|
||||
var value = CheckExpression(expression.Value);
|
||||
if (value.Type is not NubFloatType sourceFloatType)
|
||||
if (expectedType == null)
|
||||
{
|
||||
throw new TypeCheckerException(Diagnostic
|
||||
.Error("Source type of float to int conversion must be an float")
|
||||
.At(expression.Value)
|
||||
.Error("Unable to infer target type of cast")
|
||||
.At(expression)
|
||||
.WithHelp("Specify target type where value is used")
|
||||
.Build());
|
||||
}
|
||||
|
||||
var targetType = ResolveType(expression.Type);
|
||||
if (targetType is not NubIntType targetIntType)
|
||||
var value = CheckExpression(expression.Value, expectedType);
|
||||
|
||||
if (value.Type == expectedType)
|
||||
{
|
||||
Diagnostics.Add(Diagnostic
|
||||
.Warning("Target type of cast is same as the value. Cast is unnecessary")
|
||||
.At(expression)
|
||||
.Build());
|
||||
|
||||
return value;
|
||||
}
|
||||
|
||||
if (!IsCastAllowed(value.Type, expectedType, false))
|
||||
{
|
||||
throw new TypeCheckerException(Diagnostic
|
||||
.Error("Target type of float to int conversion must be an integer")
|
||||
.At(expression.Type)
|
||||
.Error($"Cannot cast from {value.Type} to {expectedType}")
|
||||
.Build());
|
||||
}
|
||||
|
||||
return new FloatToIntBuiltinNode(expression.Tokens, targetIntType, value, sourceFloatType, targetIntType);
|
||||
return new CastNode(expression.Tokens, expectedType, value);
|
||||
}
|
||||
|
||||
private static bool IsCastAllowed(NubType from, NubType to, bool strict = true)
|
||||
{
|
||||
// note(nub31): Implicit casts
|
||||
switch (from)
|
||||
{
|
||||
case NubIntType fromInt when to is NubIntType toInt && fromInt.Width < toInt.Width:
|
||||
case NubPointerType when to is NubPointerType { BaseType: NubVoidType }:
|
||||
case NubConstArrayType constArrayType1 when to is NubArrayType arrayType && constArrayType1.ElementType == arrayType.ElementType:
|
||||
case NubConstArrayType constArrayType3 when to is NubSliceType sliceType2 && constArrayType3.ElementType == sliceType2.ElementType:
|
||||
case NubCStringType when to is NubStringType:
|
||||
{
|
||||
return true;
|
||||
}
|
||||
}
|
||||
|
||||
if (!strict)
|
||||
{
|
||||
// note(nub31): Explicit casts
|
||||
switch (from)
|
||||
{
|
||||
case NubIntType when to is NubIntType:
|
||||
case NubIntType when to is NubFloatType:
|
||||
case NubFloatType when to is NubIntType:
|
||||
case NubFloatType when to is NubFloatType:
|
||||
case NubPointerType when to is NubPointerType:
|
||||
case NubPointerType when to is NubIntType:
|
||||
case NubIntType when to is NubPointerType:
|
||||
case NubCStringType when to is NubPointerType { BaseType: NubIntType { Width: 8 } }:
|
||||
{
|
||||
return true;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
return false;
|
||||
}
|
||||
|
||||
private AddressOfNode CheckAddressOf(AddressOfSyntax expression, NubType? expectedType)
|
||||
@@ -499,6 +527,13 @@ public sealed class TypeChecker
|
||||
}
|
||||
|
||||
var right = CheckExpression(expression.Right, left.Type);
|
||||
if (right.Type != left.Type)
|
||||
{
|
||||
throw new TypeCheckerException(Diagnostic
|
||||
.Error($"Expected type {left.Type} from left side of binary expression, but got {right.Type}")
|
||||
.At(expression.Right)
|
||||
.Build());
|
||||
}
|
||||
|
||||
return new BinaryExpressionNode(expression.Tokens, new NubBoolType(), left, op, right);
|
||||
}
|
||||
@@ -517,6 +552,13 @@ public sealed class TypeChecker
|
||||
}
|
||||
|
||||
var right = CheckExpression(expression.Right, left.Type);
|
||||
if (right.Type != left.Type)
|
||||
{
|
||||
throw new TypeCheckerException(Diagnostic
|
||||
.Error($"Expected type {left.Type} from left side of binary expression, but got {right.Type}")
|
||||
.At(expression.Right)
|
||||
.Build());
|
||||
}
|
||||
|
||||
return new BinaryExpressionNode(expression.Tokens, new NubBoolType(), left, op, right);
|
||||
}
|
||||
@@ -533,21 +575,36 @@ public sealed class TypeChecker
|
||||
}
|
||||
|
||||
var right = CheckExpression(expression.Right, left.Type);
|
||||
if (right.Type != left.Type)
|
||||
{
|
||||
throw new TypeCheckerException(Diagnostic
|
||||
.Error($"Expected type {left.Type} from left side of binary expression, but got {right.Type}")
|
||||
.At(expression.Right)
|
||||
.Build());
|
||||
}
|
||||
|
||||
return new BinaryExpressionNode(expression.Tokens, new NubBoolType(), left, op, right);
|
||||
}
|
||||
case BinaryOperatorSyntax.Plus:
|
||||
{
|
||||
var left = CheckExpression(expression.Left, expectedType);
|
||||
if (left.Type is not NubIntType and not NubFloatType and not NubStringType and not NubCStringType)
|
||||
if (left.Type is not NubIntType and not NubFloatType)
|
||||
{
|
||||
throw new TypeCheckerException(Diagnostic
|
||||
.Error("The plus operator must be used with int, float, cstring or string types")
|
||||
.Error("The plus operator must only be used with int and float types")
|
||||
.At(expression.Left)
|
||||
.Build());
|
||||
}
|
||||
|
||||
var right = CheckExpression(expression.Right, left.Type);
|
||||
if (right.Type != left.Type)
|
||||
{
|
||||
throw new TypeCheckerException(Diagnostic
|
||||
.Error($"Expected type {left.Type} from left side of binary expression, but got {right.Type}")
|
||||
.At(expression.Right)
|
||||
.Build());
|
||||
}
|
||||
|
||||
return new BinaryExpressionNode(expression.Tokens, left.Type, left, op, right);
|
||||
}
|
||||
case BinaryOperatorSyntax.Minus:
|
||||
@@ -565,6 +622,13 @@ public sealed class TypeChecker
|
||||
}
|
||||
|
||||
var right = CheckExpression(expression.Right, left.Type);
|
||||
if (right.Type != left.Type)
|
||||
{
|
||||
throw new TypeCheckerException(Diagnostic
|
||||
.Error($"Expected type {left.Type} from left side of binary expression, but got {right.Type}")
|
||||
.At(expression.Right)
|
||||
.Build());
|
||||
}
|
||||
|
||||
return new BinaryExpressionNode(expression.Tokens, left.Type, left, op, right);
|
||||
}
|
||||
@@ -584,6 +648,13 @@ public sealed class TypeChecker
|
||||
}
|
||||
|
||||
var right = CheckExpression(expression.Right, left.Type);
|
||||
if (right.Type != left.Type)
|
||||
{
|
||||
throw new TypeCheckerException(Diagnostic
|
||||
.Error($"Expected type {left.Type} from left side of binary expression, but got {right.Type}")
|
||||
.At(expression.Right)
|
||||
.Build());
|
||||
}
|
||||
|
||||
return new BinaryExpressionNode(expression.Tokens, left.Type, left, op, right);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user